cmd: sf/nand: Print and return failure when 0 length is passed

For sf commands, when '0' length is passed for erase, update, write or
read, there might be undesired results. Ideally '0' length means nothing to
do.

So print 'ERROR: Invalid size 0' and return cmd failure when length '0' is
passed to sf commands. Same thing applies for nand commands also.

Example:

ZynqMP> sf erase 0 0
ERROR: Invalid size 0
ZynqMP> sf write 10000 0 0
ERROR: Invalid size 0
ZynqMP> sf read 10000 0 0
ERROR: Invalid size 0
ZynqMP> sf update 1000 10000 0
ERROR: Invalid size 0
ZynqMP>

Signed-off-by: Ashok Reddy Soma <ashok.reddy.soma@amd.com>
Link: https://lore.kernel.org/r/20230516115236.22458-1-ashok.reddy.soma@amd.com
Signed-off-by: Michal Simek <michal.simek@amd.com>

diff --git a/cmd/legacy-mtd-utils.c b/cmd/legacy-mtd-utils.c
index ac7139f84d63148e08d656e54832f6a5168cc625..5903a90fe53b14b518376c6cd084e92e1b88e8e2 100644 (file)
--- a/cmd/legacy-mtd-utils.c
+++ b/cmd/legacy-mtd-utils.c
@@ -88,6 +88,11 @@ int mtd_arg_off_size(int argc, char *const argv[], int *idx, loff_t *off,
                return -1;
        }
 
+       if (*size == 0) {
+               debug("ERROR: Invalid size 0\n");
+               return -1;
+       }
+
 print:
        printf("device %d ", *idx);
        if (*size == chipsize)

diff --git a/cmd/sf.c b/cmd/sf.c
index 11b9c25896a1e82e2f7fa0b7890debd64ccd4178..55bef2f7699d90764152d2f49a7deaf9dc973c98 100644 (file)
--- a/cmd/sf.c
+++ b/cmd/sf.c
@@ -353,6 +353,11 @@ static int do_spi_flash_erase(int argc, char *const argv[])
        if (ret != 1)
                return CMD_RET_USAGE;
 
+       if (size == 0) {
+               debug("ERROR: Invalid size 0\n");
+               return CMD_RET_FAILURE;
+       }
+
        /* Consistency checking */
        if (offset + size > flash->size) {
                printf("ERROR: attempting %s past flash size (%#x)\n",