]> git.dujemihanovic.xyz Git - u-boot.git/commitdiff
net: dsa: felix: configure the in-band autoneg property based on OF node info
authorVladimir Oltean <vladimir.oltean@nxp.com>
Wed, 29 Sep 2021 15:04:40 +0000 (18:04 +0300)
committerRamon Fried <rfried.dev@gmail.com>
Tue, 23 Nov 2021 07:57:55 +0000 (09:57 +0200)
Instead of trying to guess which operating modes need in-band
negotiation to be active and which ones don't, parse the available
information from the device tree. That will be correct in the cases we
can already guess, and more.

Signed-off-by: Vladimir Oltean <vladimir.oltean@nxp.com>
Reviewed-by: Ramon Fried <rfried.dev@gmail.com>
drivers/net/mscc_eswitch/felix_switch.c

index 551fc2c9f9692c8f4571bb61e33015340a62b46b..2df8dde55fb9755444cf87273bbc382aa4f76105 100644 (file)
@@ -16,6 +16,7 @@
  */
 
 #include <dm/device_compat.h>
+#include <dm/of_extra.h>
 #include <linux/delay.h>
 #include <net/dsa.h>
 #include <asm/io.h>
@@ -210,17 +211,14 @@ static int felix_init_sxgmii(struct mii_dev *imdio, int pidx)
 static void felix_start_pcs(struct udevice *dev, int port,
                            struct phy_device *phy, struct mii_dev *imdio)
 {
-       bool autoneg = true;
-
-       if (phy->phy_id == PHY_FIXED_ID ||
-           phy->interface == PHY_INTERFACE_MODE_2500BASEX)
-               autoneg = false;
+       ofnode node = dsa_port_get_ofnode(dev, port);
+       bool inband_an = ofnode_eth_uses_inband_aneg(node);
 
        switch (phy->interface) {
        case PHY_INTERFACE_MODE_SGMII:
        case PHY_INTERFACE_MODE_2500BASEX:
        case PHY_INTERFACE_MODE_QSGMII:
-               felix_init_sgmii(imdio, port, autoneg);
+               felix_init_sgmii(imdio, port, inband_an);
                break;
        case PHY_INTERFACE_MODE_10GBASER:
        case PHY_INTERFACE_MODE_USXGMII: