]> git.dujemihanovic.xyz Git - u-boot.git/commitdiff
mkimage: fit: don't create image with 0700 permissions
authorThomas Hebb <tommyhebb@gmail.com>
Sun, 1 Mar 2020 18:47:53 +0000 (10:47 -0800)
committerTom Rini <trini@konsulko.com>
Fri, 17 Apr 2020 16:32:36 +0000 (12:32 -0400)
commit 7298e422504e ("mkimage: fit: add support to encrypt image with
aes") added a new copyfile() function as part of the FIT image creation
flow. This function as currently written creates the final image with a
mode of 0700 (before umask), differing from the old behavior of 0666.
Since there doesn't seem to be any reason to make the image executable
or non-group, non-other readable, change the mask to 0666 to preserve
the old behavior.

Fixes: 7298e422504e ("mkimage: fit: add support to encrypt image with aes")
Signed-off-by: Thomas Hebb <tommyhebb@gmail.com>
tools/fit_image.c

index dd61a816c93f65c141326f28ad9eea0028ed7488..4301b5decbba182821f7b9a01783111813c091fe 100644 (file)
@@ -642,7 +642,7 @@ static int copyfile(const char *src, const char *dst)
                goto out;
        }
 
-       fd_dst = open(dst, O_WRONLY | O_CREAT, 0700);
+       fd_dst = open(dst, O_WRONLY | O_CREAT, 0666);
        if (fd_dst < 0) {
                printf("Can't open file %s (%s)\n", dst, strerror(errno));
                goto out;