]> git.dujemihanovic.xyz Git - u-boot.git/commitdiff
tools: imx8image: fix coverity CID 184233
authorPeng Fan <peng.fan@nxp.com>
Mon, 5 Nov 2018 09:53:28 +0000 (09:53 +0000)
committerStefano Babic <sbabic@denx.de>
Tue, 6 Nov 2018 10:23:59 +0000 (11:23 +0100)
Fix:
CID 184233:    (NEGATIVE_RETURNS)
Using variable "container" as an index to array "imx_header.fhdr".

Reported-by: Coverity
Signed-off-by: Peng Fan <peng.fan@nxp.com>
tools/imx8image.c

index 019b875773be99e4183c125182005bde551e66ec..ac89c821c9ebcce4121100d3f354cb6967fd9192 100644 (file)
@@ -812,6 +812,10 @@ static int build_container(soc_type_t soc, uint32_t sector_size,
                case SCFW:
                case DATA:
                case MSG_BLOCK:
+                       if (container < 0) {
+                               fprintf(stderr, "No container found\n");
+                               exit(EXIT_FAILURE);
+                       }
                        check_file(&sbuf, img_sp->filename);
                        tmp_filename = img_sp->filename;
                        set_image_array_entry(&imx_header.fhdr[container],
@@ -825,6 +829,10 @@ static int build_container(soc_type_t soc, uint32_t sector_size,
                        break;
 
                case SECO:
+                       if (container < 0) {
+                               fprintf(stderr, "No container found\n");
+                               exit(EXIT_FAILURE);
+                       }
                        check_file(&sbuf, img_sp->filename);
                        tmp_filename = img_sp->filename;
                        set_image_array_entry(&imx_header.fhdr[container],