]> git.dujemihanovic.xyz Git - u-boot.git/commitdiff
net: dc2114x: Clean up dc21x4x_recv()
authorMarek Vasut <marek.vasut+renesas@gmail.com>
Sun, 19 Apr 2020 01:10:25 +0000 (03:10 +0200)
committermarex <marex@desktop.lan>
Fri, 1 May 2020 10:35:21 +0000 (12:35 +0200)
Clean up the driver recv code to bring it up to standards with
U-Boot coding style. No functional change.

Signed-off-by: Marek Vasut <marek.vasut+renesas@gmail.com>
Cc: Joe Hershberger <joe.hershberger@ni.com>
drivers/net/dc2114x.c

index 11ebea9c1a6520b895c40553c78ac0e1db351190..4d2e11672e131a37c975549537f22f5bf0e7fa01 100644 (file)
@@ -346,46 +346,40 @@ done:
        return status;
 }
 
-static int dc21x4x_recv(struct eth_devicedev)
+static int dc21x4x_recv(struct eth_device *dev)
 {
-       s32             status;
-       int             length    = 0;
+       int length = 0;
+       u32 status;
 
-       for ( ; ; ) {
-               status = (s32)le32_to_cpu(rx_ring[rx_new].status);
+       while (true) {
+               status = le32_to_cpu(rx_ring[rx_new].status);
 
-               if (status & R_OWN) {
+               if (status & R_OWN)
                        break;
-               }
 
                if (status & RD_LS) {
-                       /* Valid frame status.
-                        */
+                       /* Valid frame status. */
                        if (status & RD_ES) {
-
-                               /* There was an error.
-                                */
+                               /* There was an error. */
                                printf("RX error status = 0x%08X\n", status);
                        } else {
-                               /* A valid frame received.
-                                */
-                               length = (le32_to_cpu(rx_ring[rx_new].status) >> 16);
-
-                               /* Pass the packet up to the protocol
-                                * layers.
-                                */
-                               net_process_received_packet(
-                                       net_rx_packets[rx_new], length - 4);
+                               /* A valid frame received. */
+                               length = (le32_to_cpu(rx_ring[rx_new].status)
+                                         >> 16);
+
+                               /* Pass the packet up to the protocol layers */
+                               net_process_received_packet
+                                       (net_rx_packets[rx_new], length - 4);
                        }
 
-                       /* Change buffer ownership for this frame, back
-                        * to the adapter.
+                       /*
+                        * Change buffer ownership for this frame,
+                        * back to the adapter.
                         */
                        rx_ring[rx_new].status = cpu_to_le32(R_OWN);
                }
 
-               /* Update entry information.
-                */
+               /* Update entry information. */
                rx_new = (rx_new + 1) % rxRingSize;
        }