pci: pci_mvebu: Fix place of link up detection

PCI Bridge is always accessible also when link is down. So move detection
of link up from mvebu_pcie_of_to_plat() function to mvebu_pcie_valid_addr()
function which is used when accessing PCI config space.

Signed-off-by: Pali Rohár <pali@kernel.org>
Reviewed-by: Marek Behún <marek.behun@nic.cz>
Reviewed-by: Stefan Roese <sr@denx.de>

diff --git a/drivers/pci/pci_mvebu.c b/drivers/pci/pci_mvebu.c
index 173755e29914156d87d16c1b83091ef39f0b78d3..4cb237d2c45ea0c929a11e9f2651cb02ab5537ff 100644 (file)
--- a/drivers/pci/pci_mvebu.c
+++ b/drivers/pci/pci_mvebu.c
@@ -138,6 +138,10 @@ static bool mvebu_pcie_valid_addr(struct mvebu_pcie *pcie,
        if (busno == pcie->first_busno && (dev != 0 || func != 0))
                return false;
 
+       /* Access to other buses is possible when link is up */
+       if (busno != pcie->first_busno && !mvebu_pcie_link_up(pcie))
+               return false;
+
        /* On secondary bus can be only one PCIe device */
        if (busno == pcie->sec_busno && dev != 0)
                return false;
@@ -369,9 +373,6 @@ static int mvebu_pcie_probe(struct udevice *dev)
        struct pci_controller *hose = dev_get_uclass_priv(ctlr);
        u32 reg;
 
-       debug("%s: PCIe %d.%d - up, base %08x\n", __func__,
-             pcie->port, pcie->lane, (u32)pcie->base);
-
        /*
         * Change Class Code of PCI Bridge device to PCI Bridge (0x600400)
         * because default value is Memory controller (0x508000) which
@@ -603,13 +604,6 @@ static int mvebu_pcie_of_to_plat(struct udevice *dev)
        if (ret < 0)
                goto err;
 
-       /* Check link and skip ports that have no link */
-       if (!mvebu_pcie_link_up(pcie)) {
-               debug("%s: %s - down\n", __func__, pcie->name);
-               ret = -ENODEV;
-               goto err;
-       }
-
        return 0;
 
 err: