test: dm: virtio: Add test cases for virtio uclass

Now that we have a sandbox virtio transport driver, add some test
cases to test virtio uclass driver.

Signed-off-by: Bin Meng <bmeng.cn@gmail.com>
Reviewed-by: Simon Glass <sjg@chromium.org>

diff --git a/arch/Kconfig b/arch/Kconfig
index e822a0b27e354ad7ec1a1f4093ace51628745b33..9fdd2f7e66aea3f21593e4ddcc7985b7c7aa70b3 100644 (file)
--- a/arch/Kconfig
+++ b/arch/Kconfig
@@ -110,6 +110,11 @@ config SANDBOX
        imply LIBAVB
        imply CMD_AVB
        imply UDP_FUNCTION_FASTBOOT
+       imply VIRTIO_MMIO
+       imply VIRTIO_PCI
+       imply VIRTIO_SANDBOX
+       imply VIRTIO_BLK
+       imply VIRTIO_NET
 
 config SH
        bool "SuperH architecture"

diff --git a/arch/sandbox/dts/test.dts b/arch/sandbox/dts/test.dts
index 71d1b3902259afe1fd012d81c6e3ba48cf271f18..6b54115f9b28025d799b0b4c69e05d78c0fc4b90 100644 (file)
--- a/arch/sandbox/dts/test.dts
+++ b/arch/sandbox/dts/test.dts
@@ -716,6 +716,14 @@
        sandbox_tee {
                compatible = "sandbox,tee";
        };
+
+       sandbox_virtio1 {
+               compatible = "sandbox,virtio1";
+       };
+
+       sandbox_virtio2 {
+               compatible = "sandbox,virtio2";
+       };
 };
 
 #include "sandbox_pmic.dtsi"

diff --git a/configs/sandbox_noblk_defconfig b/configs/sandbox_noblk_defconfig
index 93b22401855dee16569c4ac1be51ee53f4d1b619..e71e2d3860cb42dcbbf9632192178f47b96278c6 100644 (file)
--- a/configs/sandbox_noblk_defconfig
+++ b/configs/sandbox_noblk_defconfig
@@ -171,6 +171,7 @@ CONFIG_CONSOLE_TRUETYPE_CANTORAONE=y
 CONFIG_VIDEO_SANDBOX_SDL=y
 CONFIG_OSD=y
 CONFIG_SANDBOX_OSD=y
+# CONFIG_VIRTIO_BLK is not set
 CONFIG_FS_CBFS=y
 CONFIG_FS_CRAMFS=y
 CONFIG_CMD_DHRYSTONE=y

diff --git a/test/dm/Makefile b/test/dm/Makefile
index b490cf28623ffe5c8992e434a09ed0da751e3f18..213e0fda946a0d521d9cdfed3ae1d6cabded6404 100644 (file)
--- a/test/dm/Makefile
+++ b/test/dm/Makefile
@@ -53,4 +53,5 @@ obj-$(CONFIG_MISC) += misc.o
 obj-$(CONFIG_DM_SERIAL) += serial.o
 obj-$(CONFIG_CPU) += cpu.o
 obj-$(CONFIG_TEE) += tee.o
+obj-$(CONFIG_VIRTIO_SANDBOX) += virtio.o
 endif

diff --git a/test/dm/virtio.c b/test/dm/virtio.c
new file mode 100644 (file)
index 0000000..4b317d2
--- /dev/null
+++ b/test/dm/virtio.c
@@ -0,0 +1,122 @@
+// SPDX-License-Identifier: GPL-2.0+
+/*
+ * Copyright (C) 2018, Bin Meng <bmeng.cn@gmail.com>
+ */
+
+#include <common.h>
+#include <dm.h>
+#include <virtio_types.h>
+#include <virtio.h>
+#include <virtio_ring.h>
+#include <dm/device-internal.h>
+#include <dm/uclass-internal.h>
+#include <dm/root.h>
+#include <dm/test.h>
+#include <test/ut.h>
+
+/* Basic test of the virtio uclass */
+static int dm_test_virtio_base(struct unit_test_state *uts)
+{
+       struct udevice *bus, *dev;
+       u8 status;
+
+       /* check probe success */
+       ut_assertok(uclass_first_device(UCLASS_VIRTIO, &bus));
+
+       /* check the child virtio-blk device is bound */
+       ut_assertok(device_find_first_child(bus, &dev));
+       ut_assertok(strcmp(dev->name, "virtio-blk#0"));
+
+       /* check driver status */
+       ut_assertok(virtio_get_status(dev, &status));
+       ut_asserteq(VIRTIO_CONFIG_S_ACKNOWLEDGE, status);
+
+       return 0;
+}
+DM_TEST(dm_test_virtio_base, DM_TESTF_SCAN_PDATA | DM_TESTF_SCAN_FDT);
+
+/* Test all of the virtio uclass ops */
+static int dm_test_virtio_all_ops(struct unit_test_state *uts)
+{
+       struct udevice *bus, *dev;
+       struct virtio_dev_priv *uc_priv;
+       uint offset = 0, len = 0, nvqs = 1;
+       void *buffer = NULL;
+       u8 status;
+       u32 counter;
+       u64 features;
+       struct virtqueue *vqs[2];
+
+       /* check probe success */
+       ut_assertok(uclass_first_device(UCLASS_VIRTIO, &bus));
+
+       /* check the child virtio-blk device is bound */
+       ut_assertok(device_find_first_child(bus, &dev));
+
+       /*
+        * fake the virtio device probe by filling in uc_priv->vdev
+        * which is used by virtio_find_vqs/virtio_del_vqs.
+        */
+       uc_priv = dev_get_uclass_priv(bus);
+       uc_priv->vdev = dev;
+
+       /* test virtio_xxx APIs */
+       ut_assertok(virtio_get_config(dev, offset, buffer, len));
+       ut_assertok(virtio_set_config(dev, offset, buffer, len));
+       ut_asserteq(-ENOSYS, virtio_generation(dev, &counter));
+       ut_assertok(virtio_set_status(dev, VIRTIO_CONFIG_S_DRIVER_OK));
+       ut_assertok(virtio_get_status(dev, &status));
+       ut_asserteq(VIRTIO_CONFIG_S_DRIVER_OK, status);
+       ut_assertok(virtio_reset(dev));
+       ut_assertok(virtio_get_status(dev, &status));
+       ut_asserteq(0, status);
+       ut_assertok(virtio_get_features(dev, &features));
+       ut_asserteq(VIRTIO_F_VERSION_1, features);
+       ut_assertok(virtio_set_features(dev));
+       ut_assertok(virtio_find_vqs(dev, nvqs, vqs));
+       ut_assertok(virtio_del_vqs(dev));
+       ut_assertok(virtio_notify(dev, vqs[0]));
+
+       return 0;
+}
+DM_TEST(dm_test_virtio_all_ops, DM_TESTF_SCAN_PDATA | DM_TESTF_SCAN_FDT);
+
+/* Test of the virtio driver that does not have required driver ops */
+static int dm_test_virtio_missing_ops(struct unit_test_state *uts)
+{
+       struct udevice *bus;
+
+       /* find the virtio device */
+       ut_assertok(uclass_find_device(UCLASS_VIRTIO, 1, &bus));
+
+       /*
+        * Probe the device should fail with error -ENOENT.
+        * See ops check in virtio_uclass_pre_probe().
+        */
+       ut_asserteq(-ENOENT, device_probe(bus));
+
+       return 0;
+}
+DM_TEST(dm_test_virtio_missing_ops, DM_TESTF_SCAN_PDATA | DM_TESTF_SCAN_FDT);
+
+/* Test removal of virtio device driver */
+static int dm_test_virtio_remove(struct unit_test_state *uts)
+{
+       struct udevice *bus, *dev;
+
+       /* check probe success */
+       ut_assertok(uclass_first_device(UCLASS_VIRTIO, &bus));
+
+       /* check the child virtio-blk device is bound */
+       ut_assertok(device_find_first_child(bus, &dev));
+
+       /* set driver status to VIRTIO_CONFIG_S_DRIVER_OK */
+       ut_assertok(virtio_set_status(dev, VIRTIO_CONFIG_S_DRIVER_OK));
+
+       /* check the device can be successfully removed */
+       dev->flags |= DM_FLAG_ACTIVATED;
+       ut_assertok(device_remove(bus, DM_REMOVE_ACTIVE_ALL));
+
+       return 0;
+}
+DM_TEST(dm_test_virtio_remove, DM_TESTF_SCAN_PDATA | DM_TESTF_SCAN_FDT);