]> git.dujemihanovic.xyz Git - u-boot.git/commitdiff
dfu: mtd: fix the trace when limit is reached
authorPatrick Delaunay <patrick.delaunay@foss.st.com>
Mon, 5 Jun 2023 07:52:07 +0000 (09:52 +0200)
committerDario Binacchi <dario.binacchi@amarulasolutions.com>
Fri, 13 Oct 2023 08:49:07 +0000 (10:49 +0200)
The offset variable = 'off' used in the error trace when limit is reach
on erase operation is incorect as 'erase_op.addr' is used in the loop.
This patch corrects the copy paste issue between the erase loop and
the write loop.

This patch also adds the 'remaining' information to allow to debug of
limit issues.

Fixes: 6015af28ee6d ("dfu: add backend for MTD device")
Signed-off-by: Patrick Delaunay <patrick.delaunay@foss.st.com>
Reviewed-by: Patrice Chotard <patrice.chotard@foss.st.com>
drivers/dfu/dfu_mtd.c

index 75e2f6a42151da54844b1d1483f31a5bbee98a95..50d6b17cefa6bbbcfa8ab94f5d34ad742ea49a00 100644 (file)
@@ -85,8 +85,8 @@ static int mtd_block_op(enum dfu_op op, struct dfu_entity *dfu,
 
                while (remaining) {
                        if (erase_op.addr + remaining > lim) {
-                               printf("Limit reached 0x%llx while erasing at offset 0x%llx\n",
-                                      lim, off);
+                               printf("Limit reached 0x%llx while erasing at offset 0x%llx, remaining 0x%llx\n",
+                                      lim, erase_op.addr, remaining);
                                return -EIO;
                        }