]> git.dujemihanovic.xyz Git - u-boot.git/commitdiff
fpga: virtex2: Fix printf format string warnings
authorAlexander Dahl <ada@thorsis.com>
Fri, 7 Oct 2022 12:19:57 +0000 (14:19 +0200)
committerMichal Simek <michal.simek@amd.com>
Mon, 10 Oct 2022 10:28:08 +0000 (12:28 +0200)
Warning appears if built with FPGA_DEBUG defined:

  CC      drivers/fpga/virtex2.o
/mnt/data/adahl/src/u-boot/drivers/fpga/virtex2.c: In function ‘virtex2_ssm_load’:
/mnt/data/adahl/src/u-boot/drivers/fpga/virtex2.c:333:11: warning: format ‘%d’ expects argument of type ‘int’, but argument 4 has type ‘size_t’ {aka ‘long unsigned int’} [-Wformat=]
    PRINTF("%s:%d:done went active early, bytecount = %d\n",
           ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
           __func__, __LINE__, bytecount);
                               ~~~~~~~~~
/mnt/data/adahl/src/u-boot/drivers/fpga/virtex2.c:25:37: note: in definition of macro ‘PRINTF’
 #define PRINTF(fmt, args...) printf(fmt, ##args)
                                     ^~~
/mnt/data/adahl/src/u-boot/drivers/fpga/virtex2.c: In function ‘virtex2_ss_load’:
/mnt/data/adahl/src/u-boot/drivers/fpga/virtex2.c:468:12: warning: format ‘%d’ expects argument of type ‘int’, but argument 4 has type ‘size_t’ {aka ‘long unsigned int’} [-Wformat=]
     PRINTF("%s:%d:done went active early, bytecount = %d\n",
            ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
            __func__, __LINE__, bytecount);
                                ~~~~~~~~~
/mnt/data/adahl/src/u-boot/drivers/fpga/virtex2.c:25:37: note: in definition of macro ‘PRINTF’
 #define PRINTF(fmt, args...) printf(fmt, ##args)
                                     ^~~

Signed-off-by: Alexander Dahl <ada@thorsis.com>
Signed-off-by: Michal Simek <michal.simek@amd.com>
Link: https://lore.kernel.org/r/20221007122003.11239-5-ada@thorsis.com
drivers/fpga/virtex2.c

index 51b8d3120567925f6b163ace0b2ee29501806e76..e769ceebc1553d80b9244c25ee7b59086feb0bfc 100644 (file)
@@ -330,7 +330,7 @@ static int virtex2_ssm_load(xilinx_desc *desc, const void *buf, size_t bsize)
 #endif
 
                if ((*fn->done)(cookie) == FPGA_SUCCESS) {
-                       PRINTF("%s:%d:done went active early, bytecount = %d\n",
+                       PRINTF("%s:%d:done went active early, bytecount = %zu\n",
                               __func__, __LINE__, bytecount);
                        break;
                }
@@ -465,7 +465,7 @@ static int virtex2_ss_load(xilinx_desc *desc, const void *buf, size_t bsize)
 #endif
 
                        if ((*fn->done)(cookie) == FPGA_SUCCESS) {
-                               PRINTF("%s:%d:done went active early, bytecount = %d\n",
+                               PRINTF("%s:%d:done went active early, bytecount = %zu\n",
                                       __func__, __LINE__, bytecount);
                                break;
                        }