]> git.dujemihanovic.xyz Git - u-boot.git/commitdiff
rng: meson: make core clock optional
authorNeil Armstrong <narmstrong@baylibre.com>
Fri, 25 Sep 2020 07:19:20 +0000 (09:19 +0200)
committerNeil Armstrong <narmstrong@baylibre.com>
Mon, 28 Sep 2020 07:38:11 +0000 (09:38 +0200)
This fixes HWRNG support on Amlogic GXL, GXM, G12A, G12B & SM1
based boards dues to the lack of the core clock in the device tree.

It was reported breaking EFI boot in the Linux EFI stub, because the
EFI_RNG_PROTOCOL didn't check for the RNG device presence before
installing itself.

The Linux amlogic,meson-rng.yaml doesn't mandate the core clock,
this the clock should be ignores if not present.

Nevertheless, the clock should be present and this should be fixed
on the Linux meson-gxl.dtsi & meson-g12-common.dtsi then synced
with U-Boot.

The change has been tested on a Khadas VIM3, which uses the common
meson-g12-common.dtsi like the Odroid-C4 & Odroid-N2 in Scott's
report, along with the RNG cmd.

Cc: Heinrich Schuchardt <xypron.glpk@gmx.de>
Reported-by: Scott K Logan <logans@cottsay.net>
Fixes: bc40eb278b ("drivers/rng: add Amlogic hardware RNG driver")
Signed-off-by: Neil Armstrong <narmstrong@baylibre.com>
Tested-by: Scott K Logan <logans@cottsay.net>
Signed-off-by: Neil Armstrong <narmstrong@baylibre.com>
drivers/rng/meson-rng.c

index 4b81a623535d8c632229c1b56933d7bf77d5fb76..57a5a702a23171aa955adf2b07659004769445bf 100644 (file)
@@ -90,8 +90,9 @@ static int meson_rng_ofdata_to_platdata(struct udevice *dev)
        if (!pdata->base)
                return -ENODEV;
 
+       /* Get optional "core" clock */
        err = clk_get_by_name(dev, "core", &pdata->clk);
-       if (err)
+       if (err && err != -ENODATA)
                return err;
 
        return 0;