]> git.dujemihanovic.xyz Git - u-boot.git/commit
Revert "fs: ext4: check the minimal partition size to mount"
authorSean Anderson <seanga2@gmail.com>
Sat, 30 Sep 2023 20:42:46 +0000 (16:42 -0400)
committerTom Rini <trini@konsulko.com>
Wed, 18 Oct 2023 00:50:52 +0000 (20:50 -0400)
commitbfcf7521eb73a0a38412307f6a398a0ae0d1b10d
tree56db9bf81ab47fd3bba8385772758999d4cba10e
parenta0733b3c66fceba34e5fad2c84ccbfa79ede00f3
Revert "fs: ext4: check the minimal partition size to mount"

This check breaks small partitions (under 1024 blocks) because part_length
is in units of part.blksz and not bytes. Given the purpose of this
function, we really want to make sure the partition is SUPERBLOCK_START +
SUPERBLOCK_SIZE (2048) bytes so we can call ext4_read_superblock without
error.

The obvious solution is to convert callers from things like

ext4fs_mount(part_info.size)

to

ext4fs_mount(part_info.size * part_info.blksz);

However, I'm not really a fan of the bloat that would cause, especially
since the error is now suppressed. I think the best course of action here
is to just revert the patch.

This reverts commit 9905cae65e03335aefcb1ebfab5b7ee62d89f64e.

Signed-off-by: Sean Anderson <seanga2@gmail.com>
Reviewed-by: Simon Glass <sjg@chromium.org>
Reviewed-by: Patrick Delaunay <patrick.delaunay@foss.st.com>
fs/ext4/ext4_common.c