]> git.dujemihanovic.xyz Git - u-boot.git/commit
cmd: ubi: Remove useless call to mtdparts_init()
authorBoris Brezillon <boris.brezillon@bootlin.com>
Tue, 13 Nov 2018 11:43:12 +0000 (12:43 +0100)
committerJagan Teki <jagan@amarulasolutions.com>
Tue, 13 Nov 2018 13:23:10 +0000 (18:53 +0530)
commit86dfa556d92720ca7016121787d04f13a1a0e440
treeb9c2e313a46c9488edef3ddf9c3be153779aea54
parent03303fb715ca5295b6e49c8c4865d9b50c72f36c
cmd: ubi: Remove useless call to mtdparts_init()

Commit c58fb2cdb3e4 ("cmd: ubi: clean the partition handling")
introduced a call to mtd_probe_devices() in the ubi_attach() path
and this function takes care of parsing mtdparts/mtdids and
creating/registering the associated mtd partitions.

The mtdparts_init() call in the ubi_detach() path is not only
unnecessary but can sometimes print error messages even when things
work properly (that's the case with SPI NAND devices that have not
been probed with 'mtd list'), which is misleading.

Remove this call to mtdparts_init() and drop the dependency on
CMD_MTDPARTS.

Fixes: c58fb2cdb3e4 ("cmd: ubi: clean the partition handling")
Reported-by: Stefan Roese <sr@denx.de>
Signed-off-by: Boris Brezillon <boris.brezillon@bootlin.com>
Tested-by: Stefan Roese <sr@denx.de>
Reviewed-by: Lukasz Majewski <lukma@denx.de>
Reviewed-by: Jagan Teki <jagan@openedev.com>
cmd/Kconfig
cmd/ubi.c