]> git.dujemihanovic.xyz Git - u-boot.git/commit
fastboot: fix CRC32 chunk size checking
authorWojciech Nizinski <niziak@spox.org>
Mon, 25 Sep 2023 10:37:15 +0000 (12:37 +0200)
committerMattijs Korpershoek <mkorpershoek@baylibre.com>
Tue, 31 Oct 2023 13:36:30 +0000 (14:36 +0100)
commit355aab94d1f675ec1118906e1f88dfdf6a3582eb
treed278e353aeb97ff64125738cc2ec1ff0e6bbed35
parentcbba1b7766bd93d74e28202c46e69095ac13760b
fastboot: fix CRC32 chunk size checking

genimage create android-sparse file with CRC32 chunk at end. When
U-Boot's fastboot receives this chunk it returns error message:
`Fail Bogus chunk size for chunk type Dont Care`

According to reference implementation of Android's sparse file format:

<https://android.googlesource.com/platform/system/core/+/refs/heads/main/
libsparse/output_file.cpp#513>

the chunk_header.total_sz is CHUNK_HEADER_LEN + 4 (CRC32 size).

Signed-off-by: Wojciech Nizinski <niziak@spox.org>
Reviewed-by: Mattijs Korpershoek <mkorpershoek@baylibre.com>
Tested-by: Mattijs Korpershoek <mkorpershoek@baylibre.com> # on vim3
Link: https://lore.kernel.org/r/20230925103714.4153612-1-niziak@spox.org
Signed-off-by: Mattijs Korpershoek <mkorpershoek@baylibre.com>
lib/image-sparse.c