]> git.dujemihanovic.xyz Git - u-boot.git/commit
ARM: zynq: Fix invalid check on NAND_CMD_NONE.
authorPatrick van Gelder <patrick.vangelder@nl.bosch.com>
Fri, 24 Apr 2020 07:28:56 +0000 (01:28 -0600)
committerMichal Simek <michal.simek@xilinx.com>
Mon, 27 Apr 2020 12:21:18 +0000 (14:21 +0200)
commit27d706937a5c72f0414a540ca20fd36b4b72bda7
tree9b5b7ffe47178724ab982542f03dde4d21e6782a
parent19d130450544f505589b25afc30508136ab52b71
ARM: zynq: Fix invalid check on NAND_CMD_NONE.

The end_cmd field in the variables cmd_phase_addr and data_phase_addr
contains the value 0xFF when the end_cmd equals NAND_CMD_NONE. This
should be 0x00.

This is caused by comparing NAND_CMD_NONE (int) with end_cmd (u8).
end_cmd will be promoted by the int value -1 and therefore is not equal
to 0xFF. Solved by casting NAND_CMD_NONE to u8 which will avoid int
promotion.

Signed-off-by: Patrick van Gelder <patrick.vangelder@nl.bosch.com>
Reviewed-by: T Karthik Reddy <t.karthik.reddy@xilinx.com>
Signed-off-by: Michal Simek <michal.simek@xilinx.com>
drivers/mtd/nand/raw/zynq_nand.c