From f9852acdce029edb8e1a06d1d5336b6d0a12471e Mon Sep 17 00:00:00 2001
From: Adam Ford <aford173@gmail.com>
Date: Sat, 19 Feb 2022 17:08:43 -0600
Subject: [PATCH] phy: nop-phy: Fix enabling reset
The reset function should place the phy into reset, while the
init function should take the phy out of reset. Currently the
reset function takes it out of reset, and the init calls the
reset.
Signed-off-by: Adam Ford <aford173@gmail.com>
---
drivers/phy/nop-phy.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/drivers/phy/nop-phy.c b/drivers/phy/nop-phy.c
index b08eedd4d4..e2ee6e9206 100644
--- a/drivers/phy/nop-phy.c
+++ b/drivers/phy/nop-phy.c
@@ -28,7 +28,7 @@ static int nop_phy_reset(struct phy *phy)
if (!dm_gpio_is_valid(&priv->reset_gpio))
return 0;
- return dm_gpio_set_value(&priv->reset_gpio, false);
+ return dm_gpio_set_value(&priv->reset_gpio, true);
}
#endif
@@ -44,7 +44,8 @@ static int nop_phy_init(struct phy *phy)
}
#if CONFIG_IS_ENABLED(DM_GPIO)
- ret = nop_phy_reset(phy);
+ /* Take phy out of reset */
+ ret = dm_gpio_set_value(&priv->reset_gpio, false);
if (ret) {
if (CONFIG_IS_ENABLED(CLK))
clk_disable_bulk(&priv->bulk);
--
2.39.5