From e69b187486e3b8124af966d2f20c55c8605ea1ae Mon Sep 17 00:00:00 2001 From: Heinrich Schuchardt Date: Tue, 23 Apr 2024 09:09:44 +0200 Subject: [PATCH] net: consider option-length when parsing NIS domain When parsing option 40 (network information service domain) the option length is in variable 'oplen' and not in 'size'. Addresses-Coverity-ID: 492765 Uninitialized variables (UNINIT) Fixes: 8ab388bfdbcf ("net: add support to parse the NIS domain for the dhcp options") Signed-off-by: Heinrich Schuchardt --- net/bootp.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/bootp.c b/net/bootp.c index c15472f5d3..86c56803c7 100644 --- a/net/bootp.c +++ b/net/bootp.c @@ -886,7 +886,7 @@ static void dhcp_process_options(uchar *popt, uchar *end) case 40: /* NIS Domain name */ if (net_nis_domain[0] == 0) { size = truncate_sz("NIS Domain Name", - sizeof(net_nis_domain), size); + sizeof(net_nis_domain), oplen); memcpy(&net_nis_domain, popt + 2, size); net_nis_domain[size] = 0; } -- 2.39.5