From b500447ad6aef31de75e3e9242101ae96eceb7ca Mon Sep 17 00:00:00 2001 From: Julien Masson Date: Fri, 15 Dec 2023 15:09:43 +0100 Subject: [PATCH] clk: fix clk_get_rate() always return ulong When we call clk_get_rate(), we expect to get clock rate value as ulong. In that case we should not use log_ret() macro since it use internally an int. Otherwise we may return an invalid/truncated clock rate value. Signed-off-by: Julien Masson Fixes: 5c5992cb90c ("clk: Add debugging for return values") Reviewed-by: Sean Anderson Reviewed-by: Mattijs Korpershoek Link: https://lore.kernel.org/r/87o7erv9p4.fsf@baylibre.com --- drivers/clk/clk-uclass.c | 7 +------ 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/drivers/clk/clk-uclass.c b/drivers/clk/clk-uclass.c index 3e9d68feb3..d5e2007185 100644 --- a/drivers/clk/clk-uclass.c +++ b/drivers/clk/clk-uclass.c @@ -478,7 +478,6 @@ void clk_free(struct clk *clk) ulong clk_get_rate(struct clk *clk) { const struct clk_ops *ops; - ulong ret; debug("%s(clk=%p)\n", __func__, clk); if (!clk_valid(clk)) @@ -488,11 +487,7 @@ ulong clk_get_rate(struct clk *clk) if (!ops->get_rate) return -ENOSYS; - ret = ops->get_rate(clk); - if (ret) - return log_ret(ret); - - return 0; + return ops->get_rate(clk); } struct clk *clk_get_parent(struct clk *clk) -- 2.39.5