From 6bbd7e820d3eba14eceb46c3bb42bfad1af6be3f Mon Sep 17 00:00:00 2001 From: "mwleeds@mailtundra.com" Date: Sat, 6 Apr 2024 18:47:26 -0700 Subject: [PATCH] zfs: Add a comment to clarify nvlist memory layout Signed-off-by: Phaedrus Leeds --- fs/zfs/zfs.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/fs/zfs/zfs.c b/fs/zfs/zfs.c index 14779dee32..61d58fce68 100644 --- a/fs/zfs/zfs.c +++ b/fs/zfs/zfs.c @@ -1617,6 +1617,11 @@ zfs_nvlist_lookup_nvlist(char *nvlist, char *name) &size, 0); if (!found) return 0; + + /* Allocate 12 bytes in addition to the nvlist size: One uint32 before the + * nvlist to hold the encoding method, and two zero uint32's after the + * nvlist as the NULL terminator. + */ ret = calloc(1, size + 3 * sizeof(uint32_t)); if (!ret) return 0; -- 2.39.5