From 3f05f087c37ec6b408dfd3b0a864c59749b5b8e1 Mon Sep 17 00:00:00 2001 From: Philippe Reynes Date: Thu, 9 Jan 2020 17:34:02 +0100 Subject: [PATCH] test/cmd_ut.c: fix cmd_ut_category In the function cmd_ut_category, the prefix is used with the function strncmp to know if the prefix should be removed from the test name, even if the prefix is NULL. To avoid this issue, we consider that a prefix NULL mean no prefix. So we only try to remove the prefix from the test_name if the prefix is not NULL, then we avoid to call the function strncmp with a NULL prefix. Reported-by: Coverity CID 281110 Fixes: 4ad4edfe ("cmd_ut: add a parameter prefix to the function cmd_ut_category") Signed-off-by: Philippe Reynes --- test/cmd_ut.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/test/cmd_ut.c b/test/cmd_ut.c index 400719e7b6..a3a9d49f7e 100644 --- a/test/cmd_ut.c +++ b/test/cmd_ut.c @@ -26,7 +26,7 @@ int cmd_ut_category(const char *name, const char *prefix, const char *test_name = test->name; /* Remove the prefix */ - if (!strncmp(test_name, prefix, prefix_len)) + if (prefix && !strncmp(test_name, prefix, prefix_len)) test_name += prefix_len; if (argc > 1 && strcmp(argv[1], test_name)) -- 2.39.5