From: Denys Drozdov Date: Wed, 7 Apr 2021 12:28:24 +0000 (+0300) Subject: toradex: configblock: fix module revision in config block X-Git-Tag: v2025.01-rc5-pxa1908~1910^2~3 X-Git-Url: http://git.dujemihanovic.xyz/?a=commitdiff_plain;h=fd90aca329a37eade4187ca886a8dea5c60aaba0;p=u-boot.git toradex: configblock: fix module revision in config block U-boot might display wrong module revision information for modules with an assembly version 'K'. "cfgblock create" does not takes into account all revision digits from PID8. This fix takes into account all digits of PID8 to store module revision. Signed-off-by: Denys Drozdov Reviewed-by: Oleksandr Suvorov --- diff --git a/board/toradex/common/tdx-cfg-block.c b/board/toradex/common/tdx-cfg-block.c index b00467f976..93eb20cf63 100644 --- a/board/toradex/common/tdx-cfg-block.c +++ b/board/toradex/common/tdx-cfg-block.c @@ -556,6 +556,8 @@ static int get_cfgblock_interactive(void) static int get_cfgblock_barcode(char *barcode, struct toradex_hw *tag, u32 *serial) { + char revision[3] = {barcode[6], barcode[7], '\0'}; + if (strlen(barcode) < 16) { printf("Argument too short, barcode is 16 chars long\n"); return -1; @@ -564,7 +566,7 @@ static int get_cfgblock_barcode(char *barcode, struct toradex_hw *tag, /* Get hardware information from the first 8 digits */ tag->ver_major = barcode[4] - '0'; tag->ver_minor = barcode[5] - '0'; - tag->ver_assembly = barcode[7] - '0'; + tag->ver_assembly = simple_strtoul(revision, NULL, 10); barcode[4] = '\0'; tag->prodid = simple_strtoul(barcode, NULL, 10);