From: Fabio Estevam Date: Tue, 8 Nov 2022 11:39:33 +0000 (-0300) Subject: Revert "serial: mxc: have putc use the TXFIFO" X-Git-Url: http://git.dujemihanovic.xyz/?a=commitdiff_plain;h=fc1c1760de38823edbdc2cdd9606dff938a07f6e;p=u-boot.git Revert "serial: mxc: have putc use the TXFIFO" This reverts commit c7878a0483c59c48a730123bc0f4659fd40921bf. Since commit c7878a0483c5 ("serial: mxc: have putc use the TXFIFO"), serial console corruption can be seen when priting inside board_init(). Revert it to avoid the regression. Reported-by: Tim Harvey Signed-off-by: Fabio Estevam Acked-by: Tim Harvey --- diff --git a/drivers/serial/serial_mxc.c b/drivers/serial/serial_mxc.c index 4cf79c1ca2..82c0d84628 100644 --- a/drivers/serial/serial_mxc.c +++ b/drivers/serial/serial_mxc.c @@ -311,7 +311,7 @@ static int mxc_serial_putc(struct udevice *dev, const char ch) struct mxc_serial_plat *plat = dev_get_plat(dev); struct mxc_uart *const uart = plat->reg; - if (readl(&uart->ts) & UTS_TXFULL) + if (!(readl(&uart->ts) & UTS_TXEMPTY)) return -EAGAIN; writel(ch, &uart->txd);