From: Heinrich Schuchardt <heinrich.schuchardt@canonical.com>
Date: Sat, 1 Apr 2023 05:21:55 +0000 (+0200)
Subject: efi_loader: remove duplicate assignment
X-Git-Url: http://git.dujemihanovic.xyz/?a=commitdiff_plain;h=dfd4288173245f0ea03df3e73cf62848c0212d98;p=u-boot.git

efi_loader: remove duplicate assignment

Assigning the value of a variable to itself should be avoided.

Addresses-Coverity-ID: 451089 ("Evaluation order violation")
Fixes: 180b7118bed8 ("efi_loader: fix device-path for USB devices")
Signed-off-by: Heinrich Schuchardt <heinrich.schuchardt@canonical.com>
---

diff --git a/lib/efi_loader/efi_device_path.c b/lib/efi_loader/efi_device_path.c
index f35f673ce6..8a65dda883 100644
--- a/lib/efi_loader/efi_device_path.c
+++ b/lib/efi_loader/efi_device_path.c
@@ -740,7 +740,7 @@ __maybe_unused static void *dp_fill(void *buf, struct udevice *dev)
 #endif
 #if defined(CONFIG_USB)
 		case UCLASS_MASS_STORAGE: {
-			struct blk_desc *desc = desc = dev_get_uclass_plat(dev);
+			struct blk_desc *desc = dev_get_uclass_plat(dev);
 			struct efi_device_path_controller *dp =
 				dp_fill(buf, dev->parent);