From: Heinrich Schuchardt <xypron.glpk@gmx.de>
Date: Fri, 24 Jul 2020 06:29:55 +0000 (+0200)
Subject: cmd: host: return value of do_host_bind()
X-Git-Url: http://git.dujemihanovic.xyz/?a=commitdiff_plain;h=db4ec4269eea3a1beae59d7ecc68aea98b14a471;p=u-boot.git

cmd: host: return value of do_host_bind()

When trying to bind to a non-existent file the following output is
displayed:

=> host bind 0 non_existent
Failed to access host backing file 'non_existent'
exit not allowed from main input shell.

The last line is quite unexpected and due to an incorrect return value.

If do_host_bind() fails, return CMD_RET_FAILURE (= 1).

Signed-off-by: Heinrich Schuchardt <xypron.glpk@gmx.de>
---

diff --git a/cmd/host.c b/cmd/host.c
index cd9c9677f0..ff119da738 100644
--- a/cmd/host.c
+++ b/cmd/host.c
@@ -51,7 +51,7 @@ static int do_host_bind(struct cmd_tbl *cmdtp, int flag, int argc,
 		printf("** Bad device specification %s **\n", dev_str);
 		return CMD_RET_USAGE;
 	}
-	return host_dev_bind(dev, file);
+	return !!host_dev_bind(dev, file);
 }
 
 static int do_host_info(struct cmd_tbl *cmdtp, int flag, int argc,