From: AKASHI Takahiro <takahiro.akashi@linaro.org>
Date: Fri, 8 May 2020 05:50:47 +0000 (+0900)
Subject: cmd: efidebug: fix a wrong handling of arguments
X-Git-Url: http://git.dujemihanovic.xyz/?a=commitdiff_plain;h=d67591dc22f9a6d41163fb6ba0efce5fa0598830;p=u-boot.git

cmd: efidebug: fix a wrong handling of arguments

Coverity detected a dead code, but actually there is a bug in a check
against a number of arguments. So simply fix it.

Reported-by: Coverity (CID 300330)
Signed-off-by: AKASHI Takahiro <takahiro.akashi@linaro.org>
Reviewed-by: Heinrich Schuchardt <xypron.glpk@gmx.de>
---

diff --git a/cmd/efidebug.c b/cmd/efidebug.c
index d8a76d78a3..5e3bf16573 100644
--- a/cmd/efidebug.c
+++ b/cmd/efidebug.c
@@ -602,7 +602,7 @@ static int do_efi_boot_add(cmd_tbl_t *cmdtp, int flag,
 				+ sizeof(struct efi_device_path); /* for END */
 
 	/* optional data */
-	if (argc < 6)
+	if (argc == 6)
 		lo.optional_data = NULL;
 	else
 		lo.optional_data = (const u8 *)argv[6];