From: Peng Fan <van.freenix@gmail.com>
Date: Sun, 10 Jan 2016 05:01:22 +0000 (+0800)
Subject: common: cli_simple: use strlcpy instead of strcpy
X-Git-Url: http://git.dujemihanovic.xyz/?a=commitdiff_plain;h=bb08a6e7d513cc1f591b35a6e7e68dd92078eed6;p=u-boot.git

common: cli_simple: use strlcpy instead of strcpy

Report Coverity log:
Destination buffer too small (STRING_OVERFLOW)
string_overflow: You might overrun the 1024 byte destination string
lastcommand by writing 1025 bytes from console_buffer

Signed-off-by: Peng Fan <van.freenix@gmail.com>
Cc: Heiko Schocher <hs@denx.de>
Cc: Simon Glass <sjg@chromium.org>
Cc: Tom Rini <trini@konsulko.com>
Reviewed-by: Simon Glass <sjg@chromium.org>
---

diff --git a/common/cli_simple.c b/common/cli_simple.c
index 9c3d073d58..bb96aaead6 100644
--- a/common/cli_simple.c
+++ b/common/cli_simple.c
@@ -276,7 +276,8 @@ void cli_simple_loop(void)
 
 		flag = 0;	/* assume no special flags for now */
 		if (len > 0)
-			strcpy(lastcommand, console_buffer);
+			strlcpy(lastcommand, console_buffer,
+				CONFIG_SYS_CBSIZE + 1);
 		else if (len == 0)
 			flag |= CMD_FLAG_REPEAT;
 #ifdef CONFIG_BOOT_RETRY_TIME