From: Marek BehĂșn Date: Thu, 22 Jul 2021 20:52:05 +0000 (+0200) Subject: test/py: Improve check for mksquashfs version X-Git-Url: http://git.dujemihanovic.xyz/?a=commitdiff_plain;h=89795ef3b6b2d12cffb840a98ee374d2e806aa64;p=u-boot.git test/py: Improve check for mksquashfs version Some builds of squashfs-tools append version string with "-git" or similar. The float() conversion will fail in this case. Improve the code to only convert to float() the string before the '-' character. Signed-off-by: Marek BehĂșn Reviewed-by: Simon Glass Reviewed-by: Joao Marcos Costa --- diff --git a/test/py/tests/test_fs/test_squashfs/sqfs_common.py b/test/py/tests/test_fs/test_squashfs/sqfs_common.py index 267c4b57d1..8b84c2cdca 100644 --- a/test/py/tests/test_fs/test_squashfs/sqfs_common.py +++ b/test/py/tests/test_fs/test_squashfs/sqfs_common.py @@ -146,7 +146,7 @@ def get_mksquashfs_version(): out = subprocess.run(['mksquashfs -version'], shell=True, check=True, capture_output=True, text=True) # 'out' is: mksquashfs version X (yyyy/mm/dd) ... - return float(out.stdout.split()[2]) + return float(out.stdout.split()[2].split('-')[0]) def check_mksquashfs_version(): """ Checks if mksquashfs meets the required version. """