From: Simon Glass Date: Fri, 22 Jan 2016 02:44:08 +0000 (-0700) Subject: rockchip: gpio: Read the GPIO value correctly X-Git-Url: http://git.dujemihanovic.xyz/?a=commitdiff_plain;h=7d0c2c3feb2edeff73654fb851de2580966e24c5;p=u-boot.git rockchip: gpio: Read the GPIO value correctly This function should return 0 or 1, not a mask. Fix it. Signed-off-by: Simon Glass --- diff --git a/drivers/gpio/rk_gpio.c b/drivers/gpio/rk_gpio.c index fbdf9f3fd9..a22e2195e4 100644 --- a/drivers/gpio/rk_gpio.c +++ b/drivers/gpio/rk_gpio.c @@ -53,7 +53,7 @@ static int rockchip_gpio_get_value(struct udevice *dev, unsigned offset) struct rockchip_gpio_priv *priv = dev_get_priv(dev); struct rockchip_gpio_regs *regs = priv->regs; - return readl(®s->ext_port) & OFFSET_TO_BIT(offset); + return readl(®s->ext_port) & OFFSET_TO_BIT(offset) ? 1 : 0; } static int rockchip_gpio_set_value(struct udevice *dev, unsigned offset,