From: Sean Anderson Date: Thu, 1 Feb 2024 18:18:51 +0000 (-0500) Subject: lib: sparse: Fix error checking for write_sparse_chunk_raw X-Git-Url: http://git.dujemihanovic.xyz/?a=commitdiff_plain;h=766f04a297e892d5106f7f7ac8b43c69bd8a6007;p=u-boot.git lib: sparse: Fix error checking for write_sparse_chunk_raw The return value of write_sparse_chunk_raw is unsigned, so the existing check has no effect. Use IS_ERR_VALUE to detect error instead, which is what write_sparse_chunk_raw does itself. Fixes: 62649165cb0 ("lib: sparse: Make CHUNK_TYPE_RAW buffer aligned") Reported-by: Dan Carpenter Link: https://lore.kernel.org/u-boot/1b323ec3-59b0-490b-a2f0-fd961dafcf49@moroto.mountain/ Signed-off-by: Sean Anderson Reviewed-by: Michael Trimarchi Reviewed-by: Mattijs Korpershoek Link: https://lore.kernel.org/r/20240201181851.221701-1-sean.anderson@seco.com Signed-off-by: Mattijs Korpershoek --- diff --git a/lib/image-sparse.c b/lib/image-sparse.c index f828906469..09225692e9 100644 --- a/lib/image-sparse.c +++ b/lib/image-sparse.c @@ -211,7 +211,7 @@ int write_sparse_image(struct sparse_storage *info, blks = write_sparse_chunk_raw(info, blk, blkcnt, data, response); - if (blks < 0) + if (IS_ERR_VALUE(blks)) return -1; blk += blks;