From: Simon Glass <sjg@chromium.org>
Date: Wed, 7 Jun 2017 16:28:45 +0000 (-0600)
Subject: dm: core: Supress dead-code warning in __of_get_next_child()
X-Git-Url: http://git.dujemihanovic.xyz/?a=commitdiff_plain;h=73027a853d2d9324ef2b15d5a860da3e3126321d;p=u-boot.git

dm: core: Supress dead-code warning in __of_get_next_child()

Suppress a warning on next = next->sibling.

Signed-off-by: Simon Glass <sjg@chromium.org>
Reported-by: Coverity (CID: 163245)
Fixes 644ec0a (dm: core: Add livetree access functions)
---

diff --git a/drivers/core/of_access.c b/drivers/core/of_access.c
index 94ef3cc251..93a6560496 100644
--- a/drivers/core/of_access.c
+++ b/drivers/core/of_access.c
@@ -244,6 +244,12 @@ static struct device_node *__of_get_next_child(const struct device_node *node,
 		return NULL;
 
 	next = prev ? prev->sibling : node->child;
+	/*
+	 * coverity[dead_error_line : FALSE]
+	 * Dead code here since our current implementation of of_node_get()
+	 * always returns NULL (Coverity CID 163245). But we leave it as is
+	 * since we may want to implement get/put later.
+	 */
 	for (; next; next = next->sibling)
 		if (of_node_get(next))
 			break;