From: Patrick Delaunay <patrick.delaunay@st.com>
Date: Thu, 2 Jul 2020 17:08:24 +0000 (+0200)
Subject: patman: Detect unexpected END
X-Git-Url: http://git.dujemihanovic.xyz/?a=commitdiff_plain;h=7058dd071accc0bafe5c4024e30631fb56fd7126;p=u-boot.git

patman: Detect unexpected END

Detect unexpected 'END' line when a section is not detected.

This patch detect issue when tag name for section start is misspelled,
for example 'Commit-note:' for 'Commit-notes:'

  Commit-note:
  ....
  END

Then 'Commit-note:' is removed silently by re_remove = "Commit-\w*:"
but 'END' is kept in commit message.

Signed-off-by: Patrick Delaunay <patrick.delaunay@st.com>
Reviewed-by: Simon Glass <sjg@chromium.org>
---

diff --git a/tools/patman/patchstream.py b/tools/patman/patchstream.py
index 0c68c86156..70acb09642 100644
--- a/tools/patman/patchstream.py
+++ b/tools/patman/patchstream.py
@@ -269,6 +269,10 @@ class PatchStream:
             else:
                 self.section.append(line)
 
+        # If we are not in a section, it is an unexpected END
+        elif line == 'END':
+                raise ValueError("'END' wihout section")
+
         # Detect the commit subject
         elif not is_blank and self.state == STATE_PATCH_SUBJECT:
             self.commit.subject = line