From: Timur Tabi <timur@freescale.com>
Date: Thu, 5 Jul 2012 10:33:18 +0000 (+0000)
Subject: phylib: phy_startup() should return an error code on failure
X-Git-Url: http://git.dujemihanovic.xyz/?a=commitdiff_plain;h=6e5b9ac097689e96d53f638842823fb1d1bf4223;p=u-boot.git

phylib: phy_startup() should return an error code on failure

phy_startup() calls the PHY driver's startup function, but it ignores the
return code from that function, and so it never returns any failures.

Signed-off-by: Timur Tabi <timur@freescale.com>
---

diff --git a/drivers/net/phy/phy.c b/drivers/net/phy/phy.c
index 7d327f766a..baef60f827 100644
--- a/drivers/net/phy/phy.c
+++ b/drivers/net/phy/phy.c
@@ -723,10 +723,13 @@ struct phy_device *phy_connect(struct mii_dev *bus, int addr,
 	return phydev;
 }
 
+/*
+ * Start the PHY.  Returns 0 on success, or a negative error code.
+ */
 int phy_startup(struct phy_device *phydev)
 {
 	if (phydev->drv->startup)
-		phydev->drv->startup(phydev);
+		return phydev->drv->startup(phydev);
 
 	return 0;
 }