From: Tom Rini Date: Tue, 15 Aug 2017 01:00:44 +0000 (-0400) Subject: fb_mmc.c: Correct blk_dread() return value checks X-Git-Url: http://git.dujemihanovic.xyz/?a=commitdiff_plain;h=6bafa5a4bd7c4d85f86178aee8adb6040d8df4a3;p=u-boot.git fb_mmc.c: Correct blk_dread() return value checks The function blk_dread will return -ENOSYS on failure or on success the number of blocks read, which must be the number asked to read (otherwise it failed somewhere). Correct this check. Cc: Lukasz Majewski Signed-off-by: Tom Rini --- diff --git a/common/fb_mmc.c b/common/fb_mmc.c index 2a8ba15f31..26d60b88d0 100644 --- a/common/fb_mmc.c +++ b/common/fb_mmc.c @@ -132,7 +132,7 @@ static lbaint_t fb_mmc_get_boot_header(struct blk_desc *dev_desc, /* Read the boot image header */ res = blk_dread(dev_desc, info->start, hdr_sectors, (void *)hdr); - if (res == 0) { + if (res != hdr_sectors) { error("cannot read header from boot partition"); fastboot_fail("cannot read header from boot partition"); return 0; @@ -215,7 +215,7 @@ static int fb_mmc_update_zimage(struct blk_desc *dev_desc, ramdisk_buffer = (u8 *)hdr + (hdr_sectors * info.blksz); res = blk_dread(dev_desc, ramdisk_sector_start, ramdisk_sectors, ramdisk_buffer); - if (res == 0) { + if (res != ramdisk_sectors) { error("cannot read ramdisk from boot partition"); fastboot_fail("cannot read ramdisk from boot partition"); return -1;