From: Heinrich Schuchardt <xypron.glpk@gmx.de>
Date: Sun, 14 Nov 2021 07:41:07 +0000 (+0100)
Subject: lmb: remove lmb_is_nomap() from include
X-Git-Url: http://git.dujemihanovic.xyz/?a=commitdiff_plain;h=5a515132d9f25b1ff2c15e2013de9be33bf71067;p=u-boot.git

lmb: remove lmb_is_nomap() from include

Defining static functions in includes should be avoided.
Function lmb_is_nomap() is only used in the unit test.
So move it to the unit test.

Signed-off-by: Heinrich Schuchardt <xypron.glpk@gmx.de>
Acked-by: Ilias Apalodimas <ilias.apalodimas@linaro.org>
---

diff --git a/include/lmb.h b/include/lmb.h
index 1984291132..ee5b938e19 100644
--- a/include/lmb.h
+++ b/include/lmb.h
@@ -124,13 +124,6 @@ void board_lmb_reserve(struct lmb *lmb);
 void arch_lmb_reserve(struct lmb *lmb);
 void arch_lmb_reserve_generic(struct lmb *lmb, ulong sp, ulong end, ulong align);
 
-/* Low level functions */
-
-static inline bool lmb_is_nomap(struct lmb_property *m)
-{
-	return m->flags & LMB_NOMAP;
-}
-
 #endif /* __KERNEL__ */
 
 #endif /* _LINUX_LMB_H */
diff --git a/test/lib/lmb.c b/test/lib/lmb.c
index b2c2b99ef1..157c26394d 100644
--- a/test/lib/lmb.c
+++ b/test/lib/lmb.c
@@ -12,6 +12,11 @@
 #include <test/test.h>
 #include <test/ut.h>
 
+static inline bool lmb_is_nomap(struct lmb_property *m)
+{
+	return m->flags & LMB_NOMAP;
+}
+
 static int check_lmb(struct unit_test_state *uts, struct lmb *lmb,
 		     phys_addr_t ram_base, phys_size_t ram_size,
 		     unsigned long num_reserved,