From: Simon Glass <sjg@chromium.org>
Date: Mon, 13 Feb 2023 15:56:38 +0000 (-0700)
Subject: checkpatch: Add a warning for pre-schema driver model tags
X-Git-Url: http://git.dujemihanovic.xyz/?a=commitdiff_plain;h=48be546b70f509d8ac02288fd5069913ec9196f3;p=u-boot.git

checkpatch: Add a warning for pre-schema driver model tags

Help ensure that these don't creep into development by adding a check in
checkpatch for them.

Signed-off-by: Simon Glass <sjg@chromium.org>
---

diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
index ccfcbb3e12..62b764f6c3 100755
--- a/scripts/checkpatch.pl
+++ b/scripts/checkpatch.pl
@@ -2680,6 +2680,12 @@ sub u_boot_line {
 		"DEVICE_PRIV_AUTO", $herecurr);
 	u_boot_struct_name($line, "per_device_plat_auto", "_plat",
 		"DEVICE_PLAT_AUTO", $herecurr);
+
+	# Avoid using the pre-schema driver model tags
+	if ($line =~ /^\+.*u-boot,dm-.*/) {
+		ERROR("PRE_SCHEMA",
+		      "Driver model schema uses 'bootph-...' tags now\n" . $herecurr);
+	}
 }
 
 sub exclude_global_initialisers {
diff --git a/tools/patman/test_checkpatch.py b/tools/patman/test_checkpatch.py
index 4c2ab6e590..a8bb364e42 100644
--- a/tools/patman/test_checkpatch.py
+++ b/tools/patman/test_checkpatch.py
@@ -452,6 +452,12 @@ index 0000000..2234c87
         self.check_strl("cat");
         self.check_strl("cpy");
 
+    def test_schema(self):
+        """Check for uses of strn(cat|cpy)"""
+        pm = PatchMaker()
+        pm.add_line('arch/sandbox/dts/sandbox.dtsi', '\tu-boot,dm-pre-proper;')
+        self.check_single_message(pm, 'PRE_SCHEMA', 'error')
+
 if __name__ == "__main__":
     unittest.main()
     gitutil.RunTests()