From: Simon Glass <sjg@chromium.org>
Date: Fri, 14 May 2021 01:39:22 +0000 (-0600)
Subject: reset: Avoid a warning in devm_regmap_init()
X-Git-Url: http://git.dujemihanovic.xyz/?a=commitdiff_plain;h=37e79ee0e8f93674a6247cf5c973920f18fd3578;p=u-boot.git

reset: Avoid a warning in devm_regmap_init()

The devres_alloc() function is intended to avoid the need for freeing
memory, although in practice it may not be enabled, thus leading to a true
leak.

Nevertheless this is intended. Add a comment.

Signed-off-by: Simon Glass <sjg@chromium.org>
Reported-by: Coverity (CID: 312951)
---

diff --git a/drivers/core/regmap.c b/drivers/core/regmap.c
index 3206f3d112..5f98f85cfc 100644
--- a/drivers/core/regmap.c
+++ b/drivers/core/regmap.c
@@ -293,6 +293,7 @@ struct regmap *devm_regmap_init(struct udevice *dev,
 	int rc;
 	struct regmap **mapp, *map;
 
+	/* this looks like a leak, but devres takes care of it */
 	mapp = devres_alloc(devm_regmap_release, sizeof(struct regmap *),
 			    __GFP_ZERO);
 	if (unlikely(!mapp))