From: Stefan Roese Date: Wed, 7 Apr 2021 07:12:28 +0000 (+0200) Subject: mips: octeon: cvmx-bootmem: Fix compare in "if" statement X-Git-Url: http://git.dujemihanovic.xyz/?a=commitdiff_plain;h=2b6a72ed080923efa282520ae5987221e69a91d0;p=u-boot.git mips: octeon: cvmx-bootmem: Fix compare in "if" statement While porting from the Marvell source, I introduced a bug by misplacing the parenthesis. This patch fixes this issue. Signed-off-by: Stefan Roese --- diff --git a/arch/mips/mach-octeon/cvmx-bootmem.c b/arch/mips/mach-octeon/cvmx-bootmem.c index 4b10effefb..12695df9bc 100644 --- a/arch/mips/mach-octeon/cvmx-bootmem.c +++ b/arch/mips/mach-octeon/cvmx-bootmem.c @@ -283,8 +283,8 @@ static int __cvmx_bootmem_check_version(int exact_match) int major_version; major_version = CVMX_BOOTMEM_DESC_GET_FIELD(major_version); - if (major_version > 3 || - (exact_match && major_version) != exact_match) { + if ((major_version > 3) || + (exact_match && major_version != exact_match)) { debug("ERROR: Incompatible bootmem descriptor version: %d.%d at addr: 0x%llx\n", major_version, (int)CVMX_BOOTMEM_DESC_GET_FIELD(minor_version),