From: Wolfgang Wallner <wolfgang.wallner@br-automation.com>
Date: Mon, 3 Feb 2020 10:38:05 +0000 (+0100)
Subject: gpio: intel_gpio: Clear tx state bit when setting output
X-Git-Url: http://git.dujemihanovic.xyz/?a=commitdiff_plain;h=28c626804dee51dd89a5a400e0cb663ee9cc77ed;p=u-boot.git

gpio: intel_gpio: Clear tx state bit when setting output

Add missing 'PAD_CFG0_TX_STATE' to the clear mask for pcr_clrsetbits32().
Otherwise this bit cannot be cleared again after it has been set once.

Signed-off-by: Wolfgang Wallner <wolfgang.wallner@br-automation.com>
Reviewed-by: Simon Glass <sjg@chromium.org>
Reviewed-by: Bin Meng <bmeng.cn@gmail.com>
---

diff --git a/drivers/gpio/intel_gpio.c b/drivers/gpio/intel_gpio.c
index b05cfc4aed..be91626cc5 100644
--- a/drivers/gpio/intel_gpio.c
+++ b/drivers/gpio/intel_gpio.c
@@ -41,7 +41,7 @@ static int intel_gpio_direction_output(struct udevice *dev, uint offset,
 
 	pcr_clrsetbits32(pinctrl, config_offset,
 			 PAD_CFG0_MODE_MASK | PAD_CFG0_RX_STATE |
-				  PAD_CFG0_TX_DISABLE,
+				  PAD_CFG0_TX_DISABLE | PAD_CFG0_TX_STATE,
 			 PAD_CFG0_MODE_GPIO | PAD_CFG0_RX_DISABLE |
 				  (value ? PAD_CFG0_TX_STATE : 0));