From: Pali Rohár <pali@kernel.org>
Date: Wed, 12 Jan 2022 17:20:42 +0000 (+0100)
Subject: tools: kwbimage: Check the return value of image_headersz_v1()
X-Git-Url: http://git.dujemihanovic.xyz/?a=commitdiff_plain;h=252e7c3a24fefdf88dfa3fff87e8dc4d0c7aa9cc;p=u-boot.git

tools: kwbimage: Check the return value of image_headersz_v1()

Function image_headersz_v1() may return zero on fatal errors.
In this case the function already printed an error message.

Check the return value of image_headersz_v1() in kwbimage_generate(),
and exit on zero value with EXIT_FAILURE.

Signed-off-by: Pali Rohár <pali@kernel.org>
Reviewed-by: Marek Behún <marek.behun@nic.cz>
Reviewed-by: Stefan Roese <sr@denx.de>
---

diff --git a/tools/kwbimage.c b/tools/kwbimage.c
index c0f1bdac02..a5b518f60b 100644
--- a/tools/kwbimage.c
+++ b/tools/kwbimage.c
@@ -2029,6 +2029,10 @@ static int kwbimage_generate(struct image_tool_params *params,
 
 	case 1:
 		alloc_len = image_headersz_v1(NULL);
+		if (!alloc_len) {
+			free(image_cfg);
+			exit(EXIT_FAILURE);
+		}
 		break;
 
 	default: