From: Patrick Delaunay Date: Tue, 6 Apr 2021 07:57:54 +0000 (+0200) Subject: stm32mp1: remove the board_check_usb_power function when ADC is not activated X-Git-Url: http://git.dujemihanovic.xyz/?a=commitdiff_plain;h=2214d5e54c3cd55ba1d83f18985bbcb0a9dabe1a;p=u-boot.git stm32mp1: remove the board_check_usb_power function when ADC is not activated Simplify the code of the function board_check_usb_power based in CONFIG_ADC and adc_measurement; the function is removed by the linker when the CONFIG_ADC is not activated. Signed-off-by: Patrick Delaunay Reviewed-by: Patrice Chotard Reviewed-by: Jaehoon Chung --- diff --git a/board/st/stm32mp1/stm32mp1.c b/board/st/stm32mp1/stm32mp1.c index 759181fb5d..261ec15e1b 100644 --- a/board/st/stm32mp1/stm32mp1.c +++ b/board/st/stm32mp1/stm32mp1.c @@ -347,6 +347,9 @@ static int board_check_usb_power(void) u32 nb_blink; u8 i; + if (!IS_ENABLED(CONFIG_ADC)) + return -ENODEV; + node = ofnode_path("/config"); if (!ofnode_valid(node)) { log_debug("no /config node?\n"); @@ -370,11 +373,7 @@ static int board_check_usb_power(void) /* perform maximum of 2 ADC measurements to detect power supply current */ for (i = 0; i < 2; i++) { - if (IS_ENABLED(CONFIG_ADC)) - ret = adc_measurement(node, adc_count, &min_uV, &max_uV); - else - ret = -ENODEV; - + ret = adc_measurement(node, adc_count, &min_uV, &max_uV); if (ret) return ret;