From: Simon Glass Date: Sun, 25 Jan 2015 15:27:09 +0000 (-0700) Subject: dm: sandbox: sf: Tidy up the error handling in sandbox_sf_probe() X-Git-Url: http://git.dujemihanovic.xyz/?a=commitdiff_plain;h=1603bf3cc189da65362b83b85831e094a2fe8516;p=u-boot.git dm: sandbox: sf: Tidy up the error handling in sandbox_sf_probe() Use a single exit point when we have an error and add debugging there. Signed-off-by: Simon Glass --- diff --git a/drivers/mtd/spi/sandbox.c b/drivers/mtd/spi/sandbox.c index 3024b988fe..106dda9ccc 100644 --- a/drivers/mtd/spi/sandbox.c +++ b/drivers/mtd/spi/sandbox.c @@ -141,8 +141,10 @@ static int sandbox_sf_probe(struct udevice *dev) assert(bus->seq != -1); if (bus->seq < CONFIG_SANDBOX_SPI_MAX_BUS) spec = state->spi[bus->seq][cs].spec; - if (!spec) - return -ENOENT; + if (!spec) { + ret = -ENOENT; + goto error; + } file = strchr(spec, ':'); if (!file) { @@ -196,6 +198,7 @@ static int sandbox_sf_probe(struct udevice *dev) return 0; error: + debug("%s: Got error %d\n", __func__, ret); return ret; }