From: Heinrich Schuchardt <heinrich.schuchardt@canonical.com>
Date: Thu, 1 Sep 2022 21:30:09 +0000 (+0200)
Subject: efi_loader: compliance Simple Text Input Ex Protocol
X-Git-Url: http://git.dujemihanovic.xyz/?a=commitdiff_plain;h=0b7b56d7d7446ab24d2b8da2236ec44ea7edf2cc;p=u-boot.git

efi_loader: compliance Simple Text Input Ex Protocol

We cannot expect the buffers passed to the input protocols to be zero
filled. If only modifier keys are pressed, we have to return EFI_NOT_READY
but we still have to fill the key structure.

Signed-off-by: Heinrich Schuchardt <heinrich.schuchardt@canonical.com>
Reviewed-by: Ilias Apalodimas <ilias.apalodimas@linaro.org>
---

diff --git a/lib/efi_loader/efi_console.c b/lib/efi_loader/efi_console.c
index 3164fd484e..1fcaabe1c4 100644
--- a/lib/efi_loader/efi_console.c
+++ b/lib/efi_loader/efi_console.c
@@ -987,6 +987,7 @@ static efi_status_t EFIAPI efi_cin_read_key_stroke_ex(
 	efi_cin_check();
 
 	if (!key_available) {
+		memset(key_data, 0, sizeof(struct efi_key_data));
 		ret = EFI_NOT_READY;
 		goto out;
 	}