]> git.dujemihanovic.xyz Git - u-boot.git/commitdiff
sandbox: spi: Remove an incorrect free()
authorSimon Glass <sjg@chromium.org>
Wed, 24 Feb 2016 16:14:55 +0000 (09:14 -0700)
committerSimon Glass <sjg@chromium.org>
Fri, 26 Feb 2016 15:53:10 +0000 (08:53 -0700)
We must not free data that is managed by driver mode. Remove this line,
which is a hangover from the pre-driver-model code.

This fixes a problem where 'sf probe' crashes U-Boot if the backing file
for the SPI flash cannot be found.

Signed-off-by: Simon Glass <sjg@chromium.org>
Reviewed-by: Jagan Teki <jteki@openedev.com>
Tested-by: Jagan Teki <jteki@openedev.com>
Reviewed-by: Tom Rini <trini@konsulko.com>
drivers/mtd/spi/sandbox.c

index ec07be71a1c8e18f8bda7895fea2a8e25d3b763b..53470b90ce87a96d6a7feabc9d92318da2a6c271 100644 (file)
@@ -187,7 +187,6 @@ static int sandbox_sf_probe(struct udevice *dev)
 
        sbsf->fd = os_open(pdata->filename, 02);
        if (sbsf->fd == -1) {
-               free(sbsf);
                printf("%s: unable to open file '%s'\n", __func__,
                       pdata->filename);
                ret = -EIO;