]> git.dujemihanovic.xyz Git - u-boot.git/commitdiff
usb: xhci: Fail on attempt to queue TRBs to a halted endpoint
authorHector Martin <marcan@marcan.st>
Sun, 29 Oct 2023 06:37:42 +0000 (15:37 +0900)
committerMarek Vasut <marex@denx.de>
Fri, 1 Dec 2023 13:06:04 +0000 (14:06 +0100)
This isn't going to work, don't pretend it will and then end up timing
out.

Signed-off-by: Hector Martin <marcan@marcan.st>
Reviewed-by: Marek Vasut <marex@denx.de>
drivers/usb/host/xhci-ring.c

index db8b8f200250986af254de359f55996eb9641fbd..a969eafdc8ee0ed86296d57c19e93c26fb99dcad 100644 (file)
@@ -243,7 +243,8 @@ static int prepare_ring(struct xhci_ctrl *ctrl, struct xhci_ring *ep_ring,
                puts("WARN waiting for error on ep to be cleared\n");
                return -EINVAL;
        case EP_STATE_HALTED:
-               puts("WARN halted endpoint, queueing URB anyway.\n");
+               puts("WARN endpoint is halted\n");
+               return -EINVAL;
        case EP_STATE_STOPPED:
        case EP_STATE_RUNNING:
                debug("EP STATE RUNNING.\n");