]> git.dujemihanovic.xyz Git - u-boot.git/commitdiff
mkimage: Correct file being closed twice in fit_extract_data()
authorSimon Glass <sjg@chromium.org>
Wed, 16 Mar 2016 13:45:33 +0000 (07:45 -0600)
committerTom Rini <trini@konsulko.com>
Tue, 22 Mar 2016 16:16:18 +0000 (12:16 -0400)
The code flows through to the end of the function, so we don't need another
close() before this. Remove it.

Reported-by: Coverity (CID: 138503)
Signed-off-by: Simon Glass <sjg@chromium.org>
Reviewed-by: Tom Rini <trini@konsulko.com>
tools/fit_image.c

index 31aa43cab37014e7dffcaf4bc41e3ca9bca5f591..8a93ea33f921cc0bdf55c51a2f9bc78a888f34e1 100644 (file)
@@ -446,8 +446,6 @@ static int fit_extract_data(struct image_tool_params *params, const char *fname)
                ret = -EIO;
                goto err;
        }
-       close(fd);
-
        ret = 0;
 
 err: