net: phy: xilinx: Check interface type in ->config(), not ->probe()

We want to be able to have phydev->interface uninitialized during
->probe(). We should assume that phydev->interface is initialized only
before ->config().

Signed-off-by: Marek Behún <marek.behun@nic.cz>
Reviewed-by: Ramon Fried <rfried.dev@gmail.com>

diff --git a/drivers/net/phy/xilinx_gmii2rgmii.c b/drivers/net/phy/xilinx_gmii2rgmii.c
index 635c0570efeda196eb2e6f1a7f6d2957afe86e2b..d92a364365c00599eb340d877aec8620c9dda4a4 100644 (file)
--- a/drivers/net/phy/xilinx_gmii2rgmii.c
+++ b/drivers/net/phy/xilinx_gmii2rgmii.c
@@ -26,6 +26,11 @@ static int xilinxgmiitorgmii_config(struct phy_device *phydev)
 
        debug("%s\n", __func__);
 
+       if (phydev->interface != PHY_INTERFACE_MODE_GMII) {
+               printf("Incorrect interface type\n");
+               return -EINVAL;
+       }
+
        if (!ofnode_valid(node))
                return -EINVAL;
 
@@ -114,11 +119,6 @@ static int xilinxgmiitorgmii_probe(struct phy_device *phydev)
 {
        debug("%s\n", __func__);
 
-       if (phydev->interface != PHY_INTERFACE_MODE_GMII) {
-               printf("Incorrect interface type\n");
-               return -EINVAL;
-       }
-
        phydev->flags |= PHY_FLAG_BROKEN_RESET;
 
        return 0;