]> git.dujemihanovic.xyz Git - u-boot.git/commitdiff
video: sunxi: dw-hdmi: Use DM for HVCC regulator
authorSamuel Holland <samuel@sholland.org>
Mon, 28 Nov 2022 07:02:28 +0000 (01:02 -0600)
committerAndre Przywara <andre.przywara@arm.com>
Tue, 11 Apr 2023 23:17:20 +0000 (00:17 +0100)
The HDMI PHY depends on the HVCC supply being enabled. So far we have
relied on it being enabled by an earlier firmware stage (SPL or TF-A).
Attempt to enable the regulator here, so we can remove that dependency.

Signed-off-by: Samuel Holland <samuel@sholland.org>
Signed-off-by: Andre Przywara <andre.przywara@arm.com>
Reviewed-by: Jernej Skrabec <jernej.skrabec@gmail.com>
drivers/video/sunxi/sunxi_dw_hdmi.c

index ef18d1f281fa82062075288dc01d7f683e899af4..0324a050d0322e84e6c83350cfeace62bf1619af 100644 (file)
 #include <asm/arch/lcdc.h>
 #include <linux/bitops.h>
 #include <linux/delay.h>
+#include <power/regulator.h>
 
 struct sunxi_dw_hdmi_priv {
        struct dw_hdmi hdmi;
        struct reset_ctl_bulk resets;
        struct clk_bulk clocks;
+       struct udevice *hvcc;
 };
 
 struct sunxi_hdmi_phy {
@@ -333,6 +335,9 @@ static int sunxi_dw_hdmi_probe(struct udevice *dev)
                (struct sunxi_ccm_reg *)SUNXI_CCM_BASE;
        int ret;
 
+       if (priv->hvcc)
+               regulator_set_enable(priv->hvcc, true);
+
        /* Set pll3 to 297 MHz */
        clock_set_pll3(297000000);
 
@@ -384,6 +389,10 @@ static int sunxi_dw_hdmi_of_to_plat(struct udevice *dev)
        if (ret)
                return ret;
 
+       ret = device_get_supply_regulator(dev, "hvcc-supply", &priv->hvcc);
+       if (ret)
+               priv->hvcc = NULL;
+
        return 0;
 }