]> git.dujemihanovic.xyz Git - u-boot.git/commitdiff
lib/zlib: Fix a bug when getting a gzip header extra field
authorOleksandr Suvorov <oleksandr.suvorov@foundries.io>
Thu, 15 Jun 2023 14:54:34 +0000 (17:54 +0300)
committerTom Rini <trini@konsulko.com>
Fri, 14 Jul 2023 19:21:08 +0000 (15:21 -0400)
This fixes CVE-2022-37434 [1] and bases on 2 commits from Mark
Adler's zlib master repo - the original fix of CVE bug [2] and
the fix for the fix [3].

[1]
https://github.com/advisories/GHSA-cfmr-vrgj-vqwv
[2]
https://github.com/madler/zlib/commit/eff308af425b67093bab25f80f1ae950166bece1
[3]
https://github.com/madler/zlib/commit/1eb7682f845ac9e9bf9ae35bbfb3bad5dacbd91d

Fixes: e89516f031d ("zlib: split up to match original source tree")
Signed-off-by: Oleksandr Suvorov <oleksandr.suvorov@foundries.io>
lib/zlib/inflate.c

index 30dfe155995530aaac562e3424fa3c34ec9ea96d..8f767b7b9d2d92bbca9d35337d054592922215ae 100644 (file)
@@ -455,8 +455,9 @@ int ZEXPORT inflate(z_streamp strm, int flush)
                 if (copy > have) copy = have;
                 if (copy) {
                     if (state->head != Z_NULL &&
-                        state->head->extra != Z_NULL) {
-                        len = state->head->extra_len - state->length;
+                        state->head->extra != Z_NULL &&
+                        (len = state->head->extra_len - state->length) <
+                            state->head->extra_max) {
                         zmemcpy(state->head->extra + len, next,
                                 len + copy > state->head->extra_max ?
                                 state->head->extra_max - len : copy);