]> git.dujemihanovic.xyz Git - u-boot.git/commitdiff
crypto/fsl: fsl_rsa: Fix dcache issue in the driver
authorYe Li <ye.li@nxp.com>
Wed, 28 Sep 2022 10:19:02 +0000 (15:49 +0530)
committerStefano Babic <sbabic@denx.de>
Fri, 21 Oct 2022 09:54:13 +0000 (11:54 +0200)
issue:
CAAM fails with key error when perform Modular Exponentiation
using PKHA Block in CAAM

Fix:
add flush and invalidate dcache for keys, signature
and output decrypted data processed by CAAM.

Fixes: 34276478f7 (DM: crypto/fsl - Add Freescale rsa DM driver)
Signed-off-by: Ye Li <ye.li@nxp.com>
Reviewed-by: Gaurav Jain <gaurav.jain@nxp.com>
Acked-by: Peng Fan <peng.fan@nxp.com>
drivers/crypto/fsl/fsl_rsa.c

index 897ee855eadee38ee472f5868d93d0cf860bd6f1..335b7fe25acbcf65fe6994c54ca6bdd82c51d190 100644 (file)
@@ -6,6 +6,7 @@
 
 #include <config.h>
 #include <common.h>
+#include <cpu_func.h>
 #include <dm.h>
 #include <log.h>
 #include <asm/types.h>
@@ -36,12 +37,21 @@ int fsl_mod_exp(struct udevice *dev, const uint8_t *sig, uint32_t sig_len,
 
        inline_cnstr_jobdesc_pkha_rsaexp(desc, &pkin, out, sig_len);
 
+       flush_dcache_range((ulong)sig, (ulong)sig + sig_len);
+       flush_dcache_range((ulong)prop->modulus, (ulong)(prop->modulus) + keylen);
+       flush_dcache_range((ulong)prop->public_exponent,
+                          (ulong)(prop->public_exponent) + prop->exp_len);
+       flush_dcache_range((ulong)desc, (ulong)desc + (sizeof(uint32_t) * MAX_CAAM_DESCSIZE));
+       flush_dcache_range((ulong)out, (ulong)out + sig_len);
+
        ret = run_descriptor_jr(desc);
        if (ret) {
                debug("%s: RSA failed to verify: %d\n", __func__, ret);
                return -EFAULT;
        }
 
+       invalidate_dcache_range((ulong)out, (ulong)out + sig_len);
+
        return 0;
 }