]> git.dujemihanovic.xyz Git - u-boot.git/commitdiff
Blackfin: fix timer_init()/timer_reset()
authorGraf Yang <graf.yang@analog.com>
Tue, 19 May 2009 08:40:08 +0000 (04:40 -0400)
committerMike Frysinger <vapier@gentoo.org>
Tue, 19 May 2009 08:57:33 +0000 (04:57 -0400)
The timer_init() function was not using the right csync instruction, nor
was it doing it right after disabling the core timer.

The timer_reset() function would reset the timestamp, but not the actual
timer, so there was a common edge case where get_timer() return a jump of
one timestamp (couple milliseconds) right after resetting.  This caused
many functions to improperly timeout right away.

Signed-off-by: Graf Yang <graf.yang@analog.com>
Signed-off-by: Mike Frysinger <vapier@gentoo.org>
cpu/blackfin/interrupts.c

index d4dd63610106012bf5a6b307f200a9b98dd2af5d..bf6fb4b4cf38cd19af4f0ee4852fa8f98b12fe01 100644 (file)
@@ -95,11 +95,12 @@ void udelay(unsigned long usec)
 int timer_init(void)
 {
        *pTCNTL = 0x1;
+       CSYNC();
        *pTSCALE = 0x0;
        *pTCOUNT = MAX_TIM_LOAD;
        *pTPERIOD = MAX_TIM_LOAD;
        *pTCNTL = 0x7;
-       asm("CSYNC;");
+       CSYNC();
 
        timestamp = 0;
        last_time = 0;
@@ -151,5 +152,5 @@ ulong get_timer(ulong base)
 
 void reset_timer(void)
 {
-       timestamp = 0;
+       timer_init();
 }