ram: rk3399: Simplify data training first argument

data training is using chan_info as first argument with
channel number as second argument instead of that use
dram_info as first argument so-that we can get the
chan_info at data training definition.

This was the argument handling is meaningful, readable
and it would help to add similar data training for
lpddr4 in future.

Signed-off-by: Jagan Teki <jagan@amarulasolutions.com>
Reviewed-by: Kever Yang <Kever.yang@rock-chips.com>

diff --git a/drivers/ram/rockchip/sdram_rk3399.c b/drivers/ram/rockchip/sdram_rk3399.c
index da94bbef5ddd00134916f13158796d8f54436e06..8a261e0fe91d1bd00637493843171c0cef54e1e7 100644 (file)
--- a/drivers/ram/rockchip/sdram_rk3399.c
+++ b/drivers/ram/rockchip/sdram_rk3399.c
@@ -1286,10 +1286,11 @@ static int data_training_wdql(const struct chan_info *chan, u32 channel,
        return 0;
 }
 
-static int data_training(const struct chan_info *chan, u32 channel,
+static int data_training(struct dram_info *dram, u32 channel,
                         const struct rk3399_sdram_params *params,
                         u32 training_flag)
 {
+       struct chan_info *chan = &dram->chan[channel];
        u32 *denali_phy = chan->publ->denali_phy;
        int ret;
 
@@ -1498,8 +1499,7 @@ static int switch_to_phy_index1(struct dram_info *dram,
        for (channel = 0; channel < ch_count; channel++) {
                denali_phy = dram->chan[channel].publ->denali_phy;
                clrsetbits_le32(&denali_phy[896], (0x3 << 8) | 1, 1 << 8);
-               ret = data_training(&dram->chan[channel], channel,
-                                   params, PI_FULL_TRAINING);
+               ret = data_training(dram, channel, params, PI_FULL_TRAINING);
                if (ret < 0) {
                        debug("index1 training failed\n");
                        return ret;
@@ -1662,8 +1662,7 @@ static int sdram_init(struct dram_info *dram,
                        if (params->base.dramtype == LPDDR3)
                                training_flag |= PI_CA_TRAINING;
 
-                       if (!(data_training(&dram->chan[ch], ch,
-                                           params, training_flag)))
+                       if (!(data_training(dram, ch, params, training_flag)))
                                break;
                }
                /* Computed rank with associated channel number */